Fix attribute error on _NotYetLoadedTensor after loading checkpoint into quantized model with _lazy_load()
#20121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
lantiga,
Borda,
tchaton and
justusschock
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20121 +/- ##
=======================================
Coverage 91% 91%
=======================================
Files 266 266
Lines 22976 22976
=======================================
+ Hits 20808 20810 +2
+ Misses 2168 2166 -2 |
awaelchli
changed the title
_NotYetLoadedTensor after loading checkpoint into quantized model with _lazy_load()_NotYetLoadedTensor after loading checkpoint into quantized model with _lazy_load()`
awaelchli
changed the title
_NotYetLoadedTensor after loading checkpoint into quantized model with _lazy_load()`_NotYetLoadedTensor after loading checkpoint into quantized model with _lazy_load()
Borda
approved these changes
Jul 24, 2024
|
|
||
| # Test with lazy load (LitGPT uses this) | ||
| # TODO: Replace `_lazy_load` with `torch.load(..., mmap=True)` in LitGPT | ||
| state_dict = _lazy_load(tmp_path / "checkpoint.pt") |
There was a problem hiding this comment.
how about using steps for these long tests?
https://smarie.github.io/python-pytest-steps/
There was a problem hiding this comment.
If you think it's a good idea let's open an issue? I prefer not to add the test dependency in this PR because it's a simple fix, so prefer to keep the PR minimal.
This was referenced Jul 24, 2024
ammyk9
pushed a commit
to ammyk9/pytorch-lightning
that referenced
this pull request
Aug 6, 2024
… into quantized model with `_lazy_load()` (Lightning-AI#20121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20119
📚 Documentation preview 📚: https://pytorch-lightning--20121.org.readthedocs.build/en/20121/
cc @carmocca @justusschock @awaelchli